Review main Merged

87927[TASK] Free ManyToMany tests from sys_category

Oli Bartsch CR +2 V +2 Impossible +5624 −5410 updated 02/07/25, 11:44

Commit message

To improve testing of MM scenarios for common
use cases, we now use a dedicated extension with
manual records instead of sys_category, which
comes with many special cases.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 208

Show 188 more files

Review log 1115

  1. Oli Bartsch uploaded patch set 1 01/29/25, 14:30

  2. Oli Bartsch uploaded patch set 2 02/04/25, 15:24

  3. core-ci voted on patch set 2 V -1 02/04/25, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73510

  4. Oli Bartsch uploaded patch set 3 V -1 02/05/25, 10:28

  5. core-ci voted on patch set 3 V -1 02/05/25, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73570

  6. Oli Bartsch uploaded patch set 4 V -1 02/05/25, 11:38

  7. core-ci voted on patch set 4 V +1 02/05/25, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73574

  8. Benni Mack commented on patch set 4 02/06/25, 12:30

    Should we also add this to 13.4?
  9. Oli Bartsch updated the commit message in patch set 5 V +1 02/06/25, 12:33

  10. Oli Bartsch commented on patch set 5 02/06/25, 12:34

    Reply

    Yes!
  11. core-ci voted on patch set 5 V +1 02/06/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73651

  12. Benni Mack voted on patch set 5 CR +1 V +1 02/07/25, 07:55

  13. Christian Kuhn commented on patch set 5 CR +1 V +1 02/07/25, 11:35

    AbstractActionTestCase.php:64

    these tca settings should probably be part of the base TCA files. we can do this with further changes when we start working with the test sets.

    AbstractActionTestCase.php:80

    i would have preferred more abstract namings: addRelationFromLocalSide(), addRelationFromForeignSide() and similar. We can adapt this with further patches.
  14. Oli Bartsch voted on patch set 5 CR +2 V +2 02/07/25, 11:44

  15. Oli Bartsch merged patch set 6 02/07/25, 11:44