Review main Merged

87931[TASK] Have stateless workspaces PreviewUriBuilder

Christian Kuhn CR +2 V +2 Normal +90 −115 updated 01/30/25, 18:56

Commit message

PreviewUriBuilder has two non-service properties
that are used as caches. They can be avoided by
switching to use `cache.runtime`. This makes the
service readonly and stateless.

A single-use method from WorkspaceService is
inlined along the way and some PreviewUriBuilder
service consumers are declared readonly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 812

  1. Christian Kuhn uploaded patch set 1 01/29/25, 21:39

  2. Christian Kuhn updated the commit message in patch set 2 01/29/25, 21:43

  3. Christian Kuhn updated the commit message in patch set 3 01/29/25, 21:44

  4. core-ci voted on patch set 1 V +1 01/29/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73157

  5. core-ci voted on patch set 2 V +1 01/29/25, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73158

  6. core-ci voted on patch set 3 V +1 01/29/25, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73159

  7. Christian Kuhn uploaded patch set 4 V +1 01/30/25, 12:23

  8. core-ci voted on patch set 4 V +1 01/30/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73197

  9. Garvin Hicking voted on patch set 4 CR +1 V +1 01/30/25, 17:29

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 01/30/25, 18:14

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 01/30/25, 18:56

  12. Christian Kuhn merged patch set 5 01/30/25, 18:56