Review main Merged

87932[TASK] Remove workspaces BE module cache

Christian Kuhn CR +2 V +2 Hard +101 −202 updated 01/30/25, 11:09

Commit message

The workspace BE module uses a cache that is more
harmful than good: The to be rendered data sets are
cached away, aiming to reduce query load when the
module is called over and over again for the same
page and "filter set". The cache solution has been
added more than ten years ago and is nowadays
highly questionable.

The cache collides with the general practice that
backend modules shouldn't cache such data since
good cache eviction is pretty hard to achieve in
all cases in backend modules.

Even though this cache *may* speed up repeated
clicks on the module, the cache is usually not
very effective and is also flushed often leading
to additional queries whenever DataHandler persists
something.

I've personally also seen stalled data being rendered
in the module and wondered about it, but I can not
reproduce an issue anymore, even though I'm pretty
sure it still existed. Still, the patch targets only
main/v14 since I can not pinpoint a bug directly.

The patch fully removes the workspace BE module cache
and relies on fresh data being fetched from database
each time. This avoids an entire layer of possible
bugs at the cost of a slower rendering on repeated
calls to the module for the same page. In case the
module really suffers from database load, we should
rather look on how to reduce this load. Editors will
most likely not feel a difference since the cache
often did not kick in anyway due to the repeated
flushes on data change.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/29/25, 22:17

  2. Christian Kuhn updated the commit message in patch set 2 01/29/25, 22:20

  3. core-ci voted on patch set 1 V +1 01/29/25, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73160

  4. core-ci voted on patch set 2 V +1 01/29/25, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73161

  5. Benni Mack voted on patch set 2 CR +1 V +1 01/30/25, 08:28

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 01/30/25, 10:49

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/30/25, 11:09

  8. Christian Kuhn merged patch set 3 01/30/25, 11:09