87933[FEATURE] Add ViewHelper f:if.extensionLoaded
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/backend/Classes/Security/ContentSecurityPolicy/CspModuleController.php+0 −2
- typo3/sysext/backend/Resources/Private/Templates/Security/CspModule.html+2 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106020-AddIfExtensionLoadedViewHelper.rstnew+91 −0
- typo3/sysext/fluid/Classes/ViewHelpers/If/ExtensionLoadedViewHelper.php3new+80 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/If/ExtensionLoadedViewHelperTest.phpnew+96 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Cards.html+3 −3
Review log 1319
-
Garvin Hicking uploaded patch set 1 01/29/25, 23:17
-
core-ci voted on patch set 1 V -1 01/29/25, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73162
-
Garvin Hicking uploaded patch set 2
V -101/29/25, 23:30fix test class name -
Christian Kuhn commented on patch set 2 01/29/25, 23:36
ExtensionLoadedViewHelper.php:64nit: that argument should be set required=true (next boolean method argument), should it?! -
core-ci voted on patch set 2 V +1 01/29/25, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73164
-
Garvin Hicking uploaded patch set 3
V +101/29/25, 23:37make argument required -
Garvin Hicking commented on patch set 3 01/29/25, 23:37
ExtensionLoadedViewHelper.php:64ReplyDone -
core-ci voted on patch set 3 V +1 01/29/25, 23:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73165
-
Garvin Hicking uploaded patch set 4
V +101/29/25, 23:44Refactor CSP check to use new VH -
core-ci voted on patch set 4 V +1 01/29/25, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73166
-
Georg Ringer voted on patch set 4 CR +1 V +1 01/30/25, 12:46
-
Christian Kuhn commented on patch set 4 CR -1 01/30/25, 16:08
Unresolved
we're currently sorting out details. -
Garvin Hicking commented on patch set 5
CR +1V +101/30/25, 18:56Published edit on patch set 4. -
core-ci voted on patch set 5 V +1 01/30/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73207
-
Garvin Hicking uploaded patch set 6
V +101/30/25, 19:06Support composer notation -
core-ci voted on patch set 6 V +1 01/30/25, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73208
-
Simon Praetorius commented on patch set 6 02/02/25, 13:17
ExtensionLoadedViewHelper.php:75UnresolvedI would suggest to remove this special handling since it's not implemented in other condition-based ViewHelpers that take scalar values as input (such as `f:feature`). Instead, I would adjust the example code to use `<f:if.extensionLoaded><f:else>...`. If we want to add `!` and possibly other modifiers here, this should also be added to other condition-based ViewHelpers to stay consistent. And then it should probably be something Fluid itself supports, it should not be implemented by individual ViewHelpers. -
Garvin Hicking commented on patch set 6 02/19/26, 21:17
This did not seem to take off. I'm giving up. -
Garvin Hicking abandoned the change 02/19/26, 21:17