Review main Abandoned

87933[FEATURE] Add ViewHelper f:if.extensionLoaded

Garvin Hicking CR 0 V 0 Hard +272 −7 updated 02/19/26, 21:17

Commit message

This adds a wrapper around ExtensionManagementUtility::isLoaded(),
and uses it for EXT:styleguide and the CSP module cross-reference
as an example.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 3

Files 6

Review log 1319

  1. Garvin Hicking uploaded patch set 1 01/29/25, 23:17

  2. core-ci voted on patch set 1 V -1 01/29/25, 23:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73162

  3. Garvin Hicking uploaded patch set 2 V -1 01/29/25, 23:30

    fix test class name
  4. Christian Kuhn commented on patch set 2 01/29/25, 23:36

    ExtensionLoadedViewHelper.php:64

    nit: that argument should be set required=true (next boolean method argument), should it?!
  5. core-ci voted on patch set 2 V +1 01/29/25, 23:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73164

  6. Garvin Hicking uploaded patch set 3 V +1 01/29/25, 23:37

    make argument required
  7. Garvin Hicking commented on patch set 3 01/29/25, 23:37

    ExtensionLoadedViewHelper.php:64 Reply

    Done
  8. core-ci voted on patch set 3 V +1 01/29/25, 23:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73165

  9. Garvin Hicking uploaded patch set 4 V +1 01/29/25, 23:44

    Refactor CSP check to use new VH
  10. core-ci voted on patch set 4 V +1 01/29/25, 23:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73166

  11. Georg Ringer voted on patch set 4 CR +1 V +1 01/30/25, 12:46

  12. Christian Kuhn commented on patch set 4 CR -1 01/30/25, 16:08

    Unresolved

    we're currently sorting out details.
  13. Garvin Hicking commented on patch set 5 CR +1 V +1 01/30/25, 18:56

    Published edit on patch set 4.
  14. core-ci voted on patch set 5 V +1 01/30/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73207

  15. Garvin Hicking uploaded patch set 6 V +1 01/30/25, 19:06

    Support composer notation
  16. core-ci voted on patch set 6 V +1 01/30/25, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73208

  17. Simon Praetorius commented on patch set 6 02/02/25, 13:17

    ExtensionLoadedViewHelper.php:75 Unresolved

    I would suggest to remove this special handling since it's not implemented in other condition-based ViewHelpers that take scalar values as input (such as `f:feature`). Instead, I would adjust the example code to use `<f:if.extensionLoaded><f:else>...`. If we want to add `!` and possibly other modifiers here, this should also be added to other condition-based ViewHelpers to stay consistent. And then it should probably be something Fluid itself supports, it should not be implemented by individual ViewHelpers.
  18. Garvin Hicking commented on patch set 6 02/19/26, 21:17

    This did not seem to take off. I'm giving up.
  19. Garvin Hicking abandoned the change 02/19/26, 21:17