Review main Merged

87935[TASK] Have stateless workspaces IntegrityService

Christian Kuhn CR +2 V +2 Normal +74 −130 updated 01/30/25, 11:47

Commit message

The workspaces IntegrityService carries some state
in properties around which is pretty awful when the
service is used in otherwise stateless services.
The patch changes the signatures the methods to
get the state handed over and returns updated state
instead, making it stateless.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 911

  1. Christian Kuhn uploaded patch set 1 01/30/25, 00:25

  2. core-ci voted on patch set 1 V +1 01/30/25, 00:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73167

  3. Benni Mack voted on patch set 1 CR +1 V +1 01/30/25, 07:45

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 01/30/25, 10:51

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 01/30/25, 11:09

  6. Christian Kuhn uploaded patch set 2 CR +1 V +1 01/30/25, 11:17

  7. Christian Kuhn commented on patch set 2 01/30/25, 11:19

    this is a straight-ahead rebase to resolve a merge conflict from another change. i hope its ok to merge without explicit revotes.
  8. core-ci voted on patch set 2 V +1 01/30/25, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73192

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 01/30/25, 11:29

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 01/30/25, 11:47

  11. Christian Kuhn merged patch set 3 01/30/25, 11:47