Review main Merged

87938[BUGFIX] Show workspace warning in page module as popover

Oli Bartsch CR +2 V +2 Easy +7 −2 updated 01/30/25, 11:48

Commit message

The warning whether elements are not shown due to being
deleted in a workspace is now displayed as popover to
not break, e.g. having multiple language columns (see
issue for a screenshot of such case).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Oli Bartsch uploaded patch set 1 01/30/25, 08:59

  2. Oli Bartsch updated the commit message in patch set 2 01/30/25, 09:04

  3. core-ci voted on patch set 1 V -1 01/30/25, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73186

  4. core-ci voted on patch set 2 V -1 01/30/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73187

  5. Oli Bartsch uploaded patch set 3 V -1 01/30/25, 09:26

  6. core-ci voted on patch set 3 V +1 01/30/25, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73188

  7. Christian Kuhn commented on patch set 3 CR +1 V +1 01/30/25, 10:16

    nice. thx!
  8. Garvin Hicking commented on patch set 3 CR +1 V +1 01/30/25, 11:14

    (I am not sure, if there is a specific icon for this "!", that we could use from an SVG or something like that? But also fine for me like this )
  9. Christian Kuhn voted on patch set 3 CR +2 V +2 01/30/25, 11:20

  10. Christian Kuhn merged patch set 4 01/30/25, 11:48