87940[BUGFIX] Correct Workspace Preview
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Garvin Hicking +1
- Riccardo De Contardi +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/Sass/component/forms/_form-range.scss+11 −4
- Build/Sources/Sass/workspace.scss+93 −134
- Build/Sources/TypeScript/workspaces/preview.ts+15 −37
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.html+22 −28
- typo3/sysext/workspaces/Resources/Public/Css/preview.css+18 −28
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
Review log 912
-
Benjamin Kott uploaded patch set 1 01/30/25, 11:18
-
core-ci voted on patch set 1 V +1 01/30/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73193
-
Christian Kuhn commented on patch set 1 01/30/25, 11:41
thank you. that was quick! slider is within viewport again. -
Benjamin Kott uploaded patch set 2
V +101/30/25, 11:50 -
Benjamin Kott updated the commit message in patch set 3 01/30/25, 11:52
-
core-ci voted on patch set 2 V +1 01/30/25, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73195
-
core-ci voted on patch set 3 V +1 01/30/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73196
-
Christian Kuhn commented on patch set 3 CR +1 V +1 01/30/25, 12:16
this is so much better! -
Riccardo De Contardi commented on patch set 3 V +1 01/30/25, 14:08
verified on latest main -
Garvin Hicking commented on patch set 3 CR +1 V +1 01/30/25, 14:47
Nice commit message, I could understand things 😇 -
Andreas Kienast voted on patch set 3 CR +2 V +2 01/30/25, 15:46
-
Andreas Kienast merged patch set 4 01/30/25, 15:55