Review main Merged

87940[BUGFIX] Correct Workspace Preview

Benjamin Kott CR +2 V +2 Hard +162 −233 updated 01/30/25, 15:55

Commit message

This patch addresses multiple issues with the
workspace preview.

The visibility of the range slider is now restored
by correcting the markup to be used as intended.
The labels were never meant to be placed inside
`.form-range`, as it is only a wrapper for styling
the element. Additionally, the labels are now
properly hidden when the preview is not in slide
mode. To better align with the buttons,
`.form-range-sm` is added to ensure a similar
appearance in size.

The calculation of the element’s height was invalid,
preventing it from being set to 0 or 100%. The
calculation and surrounding CSS were rewritten to
allow a simpler implementation based on percentages
instead of fixed pixel. This enables the view to
better adapt to viewport changes without requiring
recalculations.

The top bar was reorganized for improved behavior
on mobile devices, consuming less space and
providing more room for the preview. To minimize
layout shifts, the view mode switch and action
buttons are now aligned to the end of the top bar.

The CSS was modernized to simplify adjustments and
respect the user's preference for light and dark
mode in the top bar.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 912

  1. Benjamin Kott uploaded patch set 1 01/30/25, 11:18

  2. core-ci voted on patch set 1 V +1 01/30/25, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73193

  3. Christian Kuhn commented on patch set 1 01/30/25, 11:41

    thank you. that was quick! slider is within viewport again.
  4. Benjamin Kott uploaded patch set 2 V +1 01/30/25, 11:50

  5. Benjamin Kott updated the commit message in patch set 3 01/30/25, 11:52

  6. core-ci voted on patch set 2 V +1 01/30/25, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73195

  7. core-ci voted on patch set 3 V +1 01/30/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73196

  8. Christian Kuhn commented on patch set 3 CR +1 V +1 01/30/25, 12:16

    this is so much better!
  9. Riccardo De Contardi commented on patch set 3 V +1 01/30/25, 14:08

    verified on latest main
  10. Garvin Hicking commented on patch set 3 CR +1 V +1 01/30/25, 14:47

    Nice commit message, I could understand things 😇
  11. Andreas Kienast voted on patch set 3 CR +2 V +2 01/30/25, 15:46

  12. Andreas Kienast merged patch set 4 01/30/25, 15:55