Review main Merged

87942[TASK] Drop unneeded parameters from `Clipboard->confirmMsgText()`

Andreas Kienast CR +2 V +2 Easy +11 −32 updated 01/31/25, 06:29

Commit message

The following parameters have been removed from
`Clipboard->confirmMsgText()`:

* `$selectedElements`
* `$columnLabel`

The parameter `$selectedElements` is whack as it contains the items in
the clipboard, passed from the outside. We can get the items from the
clipboard directly, as we have the necessary information available.

The parameter `$columnLabel` apparently was used in the page module
context but is unused. It is removed along with the according language
label.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 812

  1. Andreas Kienast uploaded patch set 1 01/30/25, 13:38

  2. Andreas Kienast uploaded patch set 2 01/30/25, 13:39

  3. core-ci voted on patch set 1 V -1 01/30/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73199

  4. core-ci voted on patch set 2 V -1 01/30/25, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73200

  5. Andreas Kienast uploaded patch set 3 V -1 01/30/25, 13:50

  6. core-ci voted on patch set 3 V +1 01/30/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73201

  7. Andreas Kienast uploaded patch set 4 01/30/25, 15:40

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  8. core-ci voted on patch set 4 V +1 01/30/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73202

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 01/30/25, 16:09

  10. Garvin Hicking commented on patch set 4 CR +1 V +1 01/30/25, 17:33

    the xlf language prefix name for this was an omen, I guess ;)
  11. Andreas Kienast voted on patch set 4 CR +2 V +2 01/31/25, 06:29

  12. Andreas Kienast merged patch set 5 01/31/25, 06:29