Review main Abandoned

87943[TASK] Normalize clipboard data

Andreas Kienast CR 0 V 0 Hard +371 −118 updated 03/25/25, 09:00

Commit message

The clipboard now utilizes DTO classes to respresent its content in a
normalized way. This supports the IDE and helps to minimize overhead at
multiple locations in the long run.

Since the internal name for a single clipboard is "pad", naming has been
aligned with the DTO usage. The clipboard identifiers themselves are
still prefixed with `tab_` as they are persited in backend user UC.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 1319

  1. Andreas Kienast uploaded patch set 1 01/30/25, 15:40

  2. core-ci voted on patch set 1 V -1 01/30/25, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73203

  3. Christian Kuhn commented on patch set 1 01/30/25, 19:06

    Tab.php:28

    maybe remove the getters, make the properties public and use named arguments when creating these?

    TabCollection.php:31

    do we *really* need add(), or is it possible to add all tabs at once and make the class immutable this way?

    TabItem.php:35

    public, named arguments and no getters?
  4. Andreas Kienast uploaded patch set 2 V -1 01/31/25, 07:31

  5. Andreas Kienast uploaded patch set 3 01/31/25, 07:33

  6. core-ci voted on patch set 2 V -1 01/31/25, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73241

  7. core-ci voted on patch set 3 V -1 01/31/25, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73242

  8. Andreas Kienast uploaded patch set 4 V -1 01/31/25, 08:18

  9. core-ci voted on patch set 4 V +1 01/31/25, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73244

  10. Andreas Kienast commented on patch set 4 01/31/25, 15:06

    Tab.php:28 Reply

    Done

    TabCollection.php:31 Reply

    Done

    TabItem.php:35 Reply

    Done
  11. Andreas Kienast uploaded patch set 5 V +1 02/03/25, 16:00

  12. core-ci voted on patch set 5 V +1 02/03/25, 16:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73422

  13. Andreas Kienast commented on patch set 5 CR -1 02/05/25, 09:48

    on it
  14. Andreas Kienast uploaded patch set 6 CR -1 V +1 02/05/25, 10:16

  15. core-ci voted on patch set 6 V +1 02/05/25, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73568

  16. Christian Kuhn commented on patch set 6 CR +1 02/05/25, 19:31

    did not test, but this reads well.
  17. Andreas Kienast commented on patch set 6 CR -1 02/06/25, 07:43

    Unresolved

    on it
  18. Andreas Kienast marked it work in progress 02/11/25, 14:59

  19. Andreas Kienast abandoned the change 03/25/25, 09:00