Review main Merged Breaking

87948[!!!][TASK] Always update reference index in Extbase

Benni Mack CR +2 V +2 Normal +49 −36 updated 01/31/25, 14:12

Commit message

The reference index becomes more and more important. There
are nowadays thousands of tests that verify proper population
in DataHandler and the central RootlineUtility already
relies on updated data.

Extbase persistence has a toggle whether refindex is
updated. Its default is "no". That's not good when we
rely on an always updated refindex.

The patch removes the toggle and thus activates refindex
updating within Extbase. We suspect Extbase misses some
cases, this can be sorted out with dedicated patches later.
But for now, its already better when the update is always
triggered at existing places in Extbase.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 79

  1. Benni Mack uploaded patch set 1 01/31/25, 07:08

  2. core-ci voted on patch set 1 V +1 01/31/25, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73239

  3. Christian Kuhn uploaded patch set 2 V +1 01/31/25, 13:34

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 01/31/25, 13:35

  5. core-ci voted on patch set 2 V +1 01/31/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73270

  6. Andreas Kienast commented on patch set 2 CR +1 V +1 01/31/25, 13:46

    I didn't even know this exists...
  7. Stefan Bürk voted on patch set 2 CR +1 V +1 01/31/25, 14:05

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 01/31/25, 14:12

  9. Christian Kuhn merged patch set 3 01/31/25, 14:12