87951[BUGFIX] Clarify searchable TCA fields
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 35
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php6+3 −24
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+36 −61
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+38 −57
- typo3/sysext/core/Classes/Resource/Search/QueryRestrictions/SearchTermRestriction.php+38 −86
- typo3/sysext/core/Classes/Schema/Field/AbstractFieldType.php+2 −0
- typo3/sysext/core/Classes/Schema/Field/CategoryFieldType.php2+5 −0
- typo3/sysext/core/Classes/Schema/Field/CheckboxFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/ColorFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/EmailFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/FieldTypeInterface.php+1 −0
- typo3/sysext/core/Classes/Schema/Field/FileFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/FolderFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/GroupFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/ImageManipulationFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/InlineFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/InputFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/JsonFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.php+6 −0
Show 15 more files
- typo3/sysext/core/Classes/Schema/Field/LinkFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/NoneFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/NumberFieldType.php5+5 −0
- typo3/sysext/core/Classes/Schema/Field/PassthroughFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/PasswordFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/RadioFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/SelectRelationFieldType.php3+5 −0
- typo3/sysext/core/Classes/Schema/Field/SlugFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/StaticSelectFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/TextFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/Field/UserFieldType.php+6 −0
- typo3/sysext/core/Classes/Schema/Field/UuidFieldType.php+5 −0
- typo3/sysext/core/Classes/Schema/SearchableSchemaFieldsCollector.php12+21 −5
- typo3/sysext/core/Tests/Functional/Schema/SearchableSchemaFieldsCollectorTest.php+82 −6
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+1 −0
Review log 3140
Show 1115 earlier messages
-
Benni Mack uploaded patch set 1 01/31/25, 09:14
-
core-ci voted on patch set 1 V +1 01/31/25, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73247
-
Benni Mack updated the commit message in patch set 2
V +101/31/25, 09:58 -
core-ci voted on patch set 2 V +1 01/31/25, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73251
-
Daniel Windloff commented on patch set 2 01/31/25, 10:17
The method DatabaseRecordList->isTextFieldType() could be replaced as well. I suggest a second method to carify the kind of the query (->eq / ->like) to take string / integer etc. comparions into account.CategoryFieldType.php:38false as return type would be more specific -
Benni Mack uploaded patch set 3
V +101/31/25, 10:40 -
Benni Mack commented on patch set 3 01/31/25, 10:40
Thanks for the feedback!CategoryFieldType.php:38ReplyDone -
core-ci voted on patch set 3 V +1 01/31/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73252
-
Oli Bartsch commented on patch set 3 01/31/25, 11:06
NumberFieldType.php:32This should not always be true according to current state. It is never declared in the static list but always via a dedicated condition, e.g. `($fieldType === 'number' && ($fieldConfig['format'] ?? 'integer') === 'integer')`SelectRelationFieldType.php:52Why should this be true?SearchableSchemaFieldsCollector.php:44Can we just do an return array_filer on the getFields()? Setting the array key to the fieldname has IMO no effect. -
Christian Kuhn commented on patch set 3 01/31/25, 11:13
NumberFieldType.php:32Replytype number was only searchable if its int? how does that make sense?SearchableSchemaFieldsCollector.php:44Replyi like foreach better, its easier to parse in my head. it has no overhead and array key is not assigned. -
Daniel Windloff commented on patch set 3 01/31/25, 11:48
DatabaseRecordList.php:2581I suggest making this decision on comparison type an API.NumberFieldType.php:32ReplyThat's what I refer to with the type of the comparison in the query. On strings it should be ->like, on int eq. -
Benni Mack commented on patch set 3 01/31/25, 13:57
DatabaseRecordList.php:2581ReplyI don't know if we should fix this separately.NumberFieldType.php:32ReplyI don't know if we should fix this separately.SelectRelationFieldType.php:52Replyyes. should be false -
Benni Mack commented on patch set 4
V +101/31/25, 13:57Published edit on patch set 3. -
core-ci voted on patch set 4 V +1 01/31/25, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73271
-
Benni Mack commented on patch set 4 01/31/25, 14:11
SelectRelationFieldType.php:52ReplyDone
-
Benni Mack uploaded patch set 5
V +101/31/25, 22:10 -
Benni Mack commented on patch set 4 01/31/25, 22:11
DatabaseRecordList.php:2581Replysee belowNumberFieldType.php:32ReplyThis is weird, I suggest to fix it separately with a dedicated "bugfix" in this case for type=number. This patch thus makes a good pre-patch for such changes.SearchableSchemaFieldsCollector.php:44ReplyAcknowledged -
core-ci voted on patch set 5 V +1 01/31/25, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73294
-
Oli Bartsch uploaded patch set 6
V +102/03/25, 09:11 -
Oli Bartsch voted on patch set 6 CR +1 V +1 02/03/25, 09:11
-
core-ci voted on patch set 6 V -1 02/03/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73366
-
Benni Mack uploaded patch set 7
CR +1V +102/03/25, 09:51 -
core-ci voted on patch set 7 V +1 02/03/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73371
-
Daniel Windloff commented on patch set 7 02/03/25, 10:12
SearchableSchemaFieldsCollector.php:41Filter fields for $field->isSearchable() should be added.SearchableSchemaFieldsCollector.php:48Feature: Strong default, if no search fields has been configured. -
Oli Bartsch commented on patch set 7 02/03/25, 11:28
SearchableSchemaFieldsCollector.php:41Reply@benni@typo3.org, If I understand it correctly, the idea is that this overrules the new implementation but will be deprecated / removed soon.SearchableSchemaFieldsCollector.php:48ReplyCould you please elaborate? I quite don't understand this feature request. -
Daniel Windloff commented on patch set 7 02/03/25, 15:46
SearchableSchemaFieldsCollector.php:41ReplyFor TCA types with isSearchable(): false are no results possible even if they are in the list of fields. Therefore, I would remove them here.SearchableSchemaFieldsCollector.php:48ReplyThe previous code returns an empty FieldCollection, if no search fields have been configured. Now a set of meaningful fields is used. From my point of view, that change in behavior is more a feature (which I like, btw). -
Benni Mack commented on patch set 7 02/03/25, 15:58
SearchableSchemaFieldsCollector.php:48ReplyThat would have been my next step (v14 only, breaking change) -> remove "searchFields" -
Oli Bartsch uploaded patch set 8
V +102/03/25, 17:56 -
core-ci voted on patch set 8 V -1 02/03/25, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73434
-
Oli Bartsch uploaded patch set 9
V -102/03/25, 18:33 -
core-ci voted on patch set 9 V +1 02/03/25, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73437
-
Oli Bartsch voted on patch set 9 CR +1 V +1 02/03/25, 21:08
-
Oli Bartsch commented on patch set 9 02/04/25, 12:11
SearchableSchemaFieldsCollector.php:41ReplyDoneSearchableSchemaFieldsCollector.php:48ReplyDone -
Georg Ringer voted on patch set 9 CR +1 V +1 02/04/25, 12:19
-
Andreas Kienast voted on patch set 9 CR +1 V +1 02/04/25, 12:25
-
Oli Bartsch voted on patch set 9 CR +2 V +2 02/04/25, 12:38
-
Oli Bartsch merged patch set 10 02/04/25, 12:38
-
Andreas Kienast commented on patch set 10 02/05/25, 06:28
DatabaseRecordList.php:2621It looks like this removal causes failures in Postgres: https://git.typo3.org/typo3/CI/cms/-/jobs/4166480 -
Stefan Bürk commented on patch set 10 02/05/25, 08:59
DatabaseRecordList.php:2621ReplyI'd say it's not this place. Even that a like query is created, it contains a cast to text field for the column. The exception from the nightly and manualy showed, that it must be the change in the PageRecordProvider. Will have a look. -
Benni Mack commented on patch set 10 02/12/25, 08:15
DatabaseRecordList.php:2621ReplyDone