87960[BUGFIX] Allow export of records and web mounts for editors
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/87960/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/87960/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/impexp/Classes/Controller/ExportController.php+1 −1
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+45 −0
- typo3/sysext/impexp/Resources/Private/Partials/Export/Configuration.fluid.html+1 −1
- typo3/sysext/impexp/Tests/Functional/Controller/ExportControllerTest.phpnew+110 −0
- typo3/sysext/impexp/Tests/Functional/Export/WebMountsTest.phpnew+87 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/be_users_editor.csvnew+4 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseImports/tt_content-on-webmount.csvnew+3 −0
Review log 811
-
Georg Ringer uploaded patch set 1 01/31/25, 12:25
-
Georg Ringer commented on patch set 1 01/31/25, 12:25
This change is ready for review. -
core-ci voted on patch set 1 V -1 01/31/25, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73266
-
Georg Ringer uploaded patch set 2
V -102/03/25, 19:49 -
core-ci voted on patch set 2 V -1 02/03/25, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73440
-
Andreas Kienast commented on patch set 2 CR -1 03/26/25, 14:21
Unresolved
The patch is flawed for several reaons: * phpstan annotates a real issue (`$inputData` is accessed before it's defined) * the additional check looks "random" * it's still not possible to do an export from the root level, no records are shown at all -
Benni Mack commented on patch set 2 CR -1 04/12/25, 11:20
Just re-checked. This change allows to show the Export module via Context Menu on PID=0 for editors (if options.impexp.enableExportForNonAdminUser = 1 is set). Once this is enabled, I still cannot export all of my webmounts... This needs more work. I set this to WIP once this has been adapted. -
Benni Mack marked it work in progress 04/12/25, 11:20
-
Georg Ringer uploaded patch set 3
CR -1V -109/17/26, 18:33 -
Georg Ringer commented on patch set 3 09/17/26, 18:33
This change is ready for review. -
core-ci voted on patch set 3 V +1 09/17/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108761