Review main Ready for review Stale

87960[BUGFIX] Allow export of records and web mounts for editors

Georg Ringer CR 0 V 0 Hard +251 −2 updated 09/17/26, 18:40

Commit message

Editors allowed to use EXT:impexp via user TSconfig
options.impexp.enableExportForNonAdminUser could not use it at all:

* The context menu of a non-page record submits no page id, so the
  module checked access to page 0, which no editor can have. That
  check now only applies if a page was actually requested. The
  exported data itself stays guarded by the web mount and
  tables_select checks in Export.
* An export starting at the root level returned no pages, because
  the page tree was built from the pages with pid=0, which are then
  dropped again by the web mount filter. For non-admin users the web
  mounts are now the entry points of that tree.

Additionally the record title is no longer escaped twice: it is
already prepared as HTML by BackendUtility::getRecordTitle().

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/87960/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/60/87960/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Georg Ringer uploaded patch set 1 01/31/25, 12:25

  2. Georg Ringer commented on patch set 1 01/31/25, 12:25

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 01/31/25, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73266

  4. Georg Ringer uploaded patch set 2 V -1 02/03/25, 19:49

  5. core-ci voted on patch set 2 V -1 02/03/25, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73440

  6. Andreas Kienast commented on patch set 2 CR -1 03/26/25, 14:21

    Unresolved

    The patch is flawed for several reaons: * phpstan annotates a real issue (`$inputData` is accessed before it's defined) * the additional check looks "random" * it's still not possible to do an export from the root level, no records are shown at all
  7. Benni Mack commented on patch set 2 CR -1 04/12/25, 11:20

    Just re-checked. This change allows to show the Export module via Context Menu on PID=0 for editors (if options.impexp.enableExportForNonAdminUser = 1 is set). Once this is enabled, I still cannot export all of my webmounts... This needs more work. I set this to WIP once this has been adapted.
  8. Benni Mack marked it work in progress 04/12/25, 11:20

  9. Georg Ringer uploaded patch set 3 CR -1 V -1 09/17/26, 18:33

  10. Georg Ringer commented on patch set 3 09/17/26, 18:33

    This change is ready for review.
  11. core-ci voted on patch set 3 V +1 09/17/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108761