Review main Merged

87964[BUGFIX] Ignore sys_template's on pid 0 in TypoScript module

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 01/31/25, 15:06

Commit message

sys_template rows shouldn't exist on pid 0, they are
ignored in FE and usually can't be added using the BE.
If there are some, the TypoScript BE record overview
fails, though. Sanitize this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jan Delius +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jan Delius +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/31/25, 14:11

  2. core-ci voted on patch set 1 V +1 01/31/25, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73272

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 01/31/25, 14:32

  4. Jan Delius commented on patch set 1 CR +1 V +1 01/31/25, 14:47

    I checked the same fix in a v12. Works well
  5. Christian Kuhn commented on patch set 1 CR +2 V +2 01/31/25, 14:53

    thanks for quick reviews!
  6. Christian Kuhn merged patch set 2 01/31/25, 15:06