Review main Merged

87968[TASK] Use BU::getRecord() instead of recordInfo() in DH

Christian Kuhn CR +2 V +2 Normal +16 −40 updated 01/31/25, 17:53

Commit message

One major issue DataHandler suffers from both performance
and complexity wise, is the fact that it tends to fetch
the same record from DB over and over again.

To start fixing this issue, we need to prepare the
codebase a bit, first.

Of course, DH uses not one, but two different solutions
to fetch a single record: There is DH->recordInfo() and
BackendUtility::getRecord(). Their implementations is
essentially identical.

The patch switches from DH->recordInfo() to BU::getRecord()
and removes `@internal` recordInfo().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/31/25, 15:42

  2. core-ci voted on patch set 1 V -1 01/31/25, 15:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73278

  3. Christian Kuhn uploaded patch set 2 V -1 01/31/25, 16:16

  4. core-ci voted on patch set 2 V +1 01/31/25, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73280

  5. Benni Mack voted on patch set 2 CR +1 V +1 01/31/25, 16:33

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 01/31/25, 17:46

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 01/31/25, 17:53

  8. Christian Kuhn merged patch set 3 01/31/25, 17:53