Review main Merged

87970[TASK] Inline a FileExtensionFilter DH call to DH

Christian Kuhn CR +2 V +2 Easy +15 −22 updated 01/31/25, 19:43

Commit message

FileExtensionFilter->filter() is the only place that
calls the low level method DataHandler->deleteAction()
instead of using proper DH higher level API methods.

This functionality is only triggered from DH itself
in checkValue_file_processDBdata() and is a misuse:
When the FAL "which file types are allowed" filter
class removes some references from a given set, it
shouldn't remove such DB references itself. DH should.

The patch inlines the DH removal code to DH which
allows protecting `@internal` DH->deleteAction().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 01/31/25, 17:48

  2. core-ci voted on patch set 1 V -1 01/31/25, 17:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73284

  3. Christian Kuhn updated the commit message in patch set 2 V -1 01/31/25, 17:55

  4. Christian Kuhn uploaded patch set 3 01/31/25, 17:55

  5. core-ci voted on patch set 2 V -1 01/31/25, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73285

  6. core-ci voted on patch set 3 V +1 01/31/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73286

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 01/31/25, 18:09

  8. Benni Mack voted on patch set 3 CR +1 V +1 01/31/25, 18:35

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 01/31/25, 19:43

  10. Christian Kuhn merged patch set 4 01/31/25, 19:43