Review 13.4 Merged

87972[TASK] Inline a FileExtensionFilter DH call to DH

Christian Kuhn CR +2 V +2 Easy +14 −21 updated 01/31/25, 19:44

Commit message

FileExtensionFilter->filter() is the only place that
calls the low level method DataHandler->deleteAction()
instead of using proper DH higher level API methods.

This functionality is only triggered from DH itself
in checkValue_file_processDBdata() and is a misuse:
When the FAL "which file types are allowed" filter
class removes some references from a given set, it
shouldn't remove such DB references itself. DH should.

The patch inlines the DH removal code to DH.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 01/31/25, 19:35

  2. core-ci voted on patch set 1 V +1 01/31/25, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73290

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 01/31/25, 19:44

  4. Christian Kuhn merged patch set 2 01/31/25, 19:44