Review main Merged

87975[BUGFIX] Evaluate GFX[avif_quality] when writing AVIF files

Garvin Hicking CR +2 V +2 Easy +11 −0 updated 02/03/25, 09:21

Commit message

The option "avif_quality" was only evaluated for GIFBUILDER
image creation.

This setting is now also applied to normal crop and resize
operations through ImageMagick/GraphicsMagick.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 810

  1. Garvin Hicking uploaded patch set 1 02/01/25, 01:01

  2. core-ci voted on patch set 1 V +1 02/01/25, 01:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73297

  3. Garvin Hicking updated the commit message in patch set 2 V +1 02/01/25, 01:09

  4. core-ci voted on patch set 2 V +1 02/01/25, 01:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73299

  5. Simon Schaufelberger commented on patch set 2 02/01/25, 08:45

    GraphicalFunctions.php:440

    I would use elseif here to not execute the check if the file extension is webp.
  6. Garvin Hicking commented on patch set 2 02/01/25, 10:02

    GraphicalFunctions.php:440 Reply

    I actually thought about this. I went with its own condition to fit the existing flow here, jpeg-webp above was also no elseif. So if it should be done it would probably better be to use match/switch, but that would make the code review more obfuscated. I think this solution is less "intrusive". I'm happy to change this if there is common demand for it, but personally would keep it like this...
  7. Stefan Bürk commented on patch set 2 CR +1 V +1 02/03/25, 07:21

    GraphicalFunctions.php:440 Reply

    Fine with this. This method already has to much if-then-else / if-then-else-elseif blocks gluttered together. Out of the scope for this.
  8. Benni Mack voted on patch set 2 CR +1 V +1 02/03/25, 08:34

  9. Garvin Hicking voted on patch set 2 CR +2 V +2 02/03/25, 09:11

  10. Garvin Hicking merged patch set 3 02/03/25, 09:21