87975[BUGFIX] Evaluate GFX[avif_quality] when writing AVIF files
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 810
-
Garvin Hicking uploaded patch set 1 02/01/25, 01:01
-
core-ci voted on patch set 1 V +1 02/01/25, 01:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73297
-
Garvin Hicking updated the commit message in patch set 2
V +102/01/25, 01:09 -
core-ci voted on patch set 2 V +1 02/01/25, 01:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73299
-
Simon Schaufelberger commented on patch set 2 02/01/25, 08:45
-
Garvin Hicking commented on patch set 2 02/01/25, 10:02
GraphicalFunctions.php:440ReplyI actually thought about this. I went with its own condition to fit the existing flow here, jpeg-webp above was also no elseif. So if it should be done it would probably better be to use match/switch, but that would make the code review more obfuscated. I think this solution is less "intrusive". I'm happy to change this if there is common demand for it, but personally would keep it like this... -
Stefan Bürk commented on patch set 2 CR +1 V +1 02/03/25, 07:21
GraphicalFunctions.php:440ReplyFine with this. This method already has to much if-then-else / if-then-else-elseif blocks gluttered together. Out of the scope for this. -
Benni Mack voted on patch set 2 CR +1 V +1 02/03/25, 08:34
-
Garvin Hicking voted on patch set 2 CR +2 V +2 02/03/25, 09:11
-
Garvin Hicking merged patch set 3 02/03/25, 09:21
GraphicalFunctions.php:440