87982[!!!][TASK] Add setRequest and getRequest to extbase ValidatorInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-106056-AddSetRequestAndGetRequestToExtbaseValidatorInterface.rst3new+43 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractCompositeValidator.php+12 −0
- typo3/sysext/extbase/Classes/Validation/Validator/AbstractValidator.php+0 −6
- typo3/sysext/extbase/Classes/Validation/Validator/ValidatorInterface.php+11 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+1 −11
- typo3/sysext/extbase/Tests/Functional/Validation/Validator/ConjunctionValidatorTest.php+11 −11
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+5 −5
Review log 1216
-
Torben Hansen uploaded patch set 1 02/02/25, 18:22
-
Torben Hansen marked it work in progress 02/02/25, 18:22
-
core-ci voted on patch set 1 V +1 02/02/25, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73338
-
Christian Kuhn commented on patch set 1 02/07/25, 12:33
agreed -
Torben Hansen uploaded patch set 2
V +103/08/25, 06:17 -
Torben Hansen marked it ready for review 03/08/25, 06:17
-
core-ci voted on patch set 2 V +1 03/08/25, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75343
-
Garvin Hicking commented on patch set 2 03/08/25, 09:50
Breaking-106056-AddSetRequestAndGetRequestToExtbaseValidatorInterface.rst:22Should we soften this by mentioning it's part of the Abstract already, and if you inherit from that you don't need to take care? I guess "real-life" impact is really low and the wording could reflect that to prevent confusion about the need to adapt validators? Also we could mention that the set/getRequest methods can be copied from the abstract if a non-abstract implementation is created in the same sentence? -
Torben Hansen uploaded patch set 3
V +103/08/25, 10:58 -
core-ci voted on patch set 3 V +1 03/08/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75350
-
Torben Hansen commented on patch set 3 03/08/25, 11:07
Breaking-106056-AddSetRequestAndGetRequestToExtbaseValidatorInterface.rst:22ReplyI added a note in the "Migratrion" section that we recommend to use `AbstractValidator` if possible. I however do not think it is useful to soften the "Impact" section or describe that `TYPO3\CMS\Extbase\Validation\Validator\AbstractValidator` already implements both methods. As you wrote, real life impact is low and I could only find a few extensions in TER exclusively (and wrongly) implementing `ValidatorInterface`. -
Garvin Hicking commented on patch set 4
V +103/08/25, 13:23Published edit on patch set 3. -
Garvin Hicking commented on patch set 4 CR +1 V +1 03/08/25, 13:24
Breaking-106056-AddSetRequestAndGetRequestToExtbaseValidatorInterface.rst:22ReplyThanks, your change is all I wanted/needed! :) -
core-ci voted on patch set 4 V +1 03/08/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75351
-
Benni Mack voted on patch set 4 CR +2 V +2 03/08/25, 20:03
-
Benni Mack merged patch set 5 03/08/25, 20:03