Review main Abandoned

87989[BUGFIX] Fix language fallback overlay order

Garvin Hicking CR 0 V 0 Easy +1 −2 updated 03/28/25, 15:59

Commit message

Proof of concept, quoted from the issue:

  The "array_reverse" is only for the overlay mechanism a few lines
  later (works with array_pop), but not for the 'pages' overlay. The
  regular pages language overlays need the fallback chain in the
  "regular" order.

  So the solution should be, just move the array_reverse next to
  the section which does regular content/record overlays.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Garvin Hicking uploaded patch set 1 02/03/25, 08:59

  2. core-ci voted on patch set 1 V +1 02/03/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73364

  3. Benni Mack commented on patch set 1 03/22/25, 17:45

    Patch itself seems reasonable, I just don't know a) why we need to do the array_reverse in one case and not in the other b) how to create a useful test (must be in SiteHandling/LinkGeneration)
  4. Benni Mack abandoned the change 03/28/25, 15:59