Review main Merged

87991[TASK] Improve error message when clearing caches fails

Garvin Hicking CR +2 V +2 Easy +3 −2 updated 03/02/25, 10:28

Commit message

When clearing the cache via the Install Tool, it may fail
due to some possible scenarios. The error message currently
only hinted at broken extensions or missing database tables.

It is now enhanced to also mention the following scenarios:

* no longer having an active install tool login session
* PHP parse errors
* JavaScript failures

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Sebastian Iffland +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Garvin Hicking uploaded patch set 1 02/03/25, 09:20

  2. core-ci voted on patch set 1 V +1 02/03/25, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73368

  3. Mathias Brodala commented on patch set 1 02/03/25, 09:41

    Would it make sense to display the actual HTTP response code and body for an even better UX?
  4. Garvin Hicking commented on patch set 1 02/03/25, 10:57

    Reply

    Unsure; probably this will be a generic HTTP/500 or the HTML of the login mask...
  5. Christian Kuhn voted on patch set 1 CR +1 V +1 02/28/25, 12:16

  6. Sebastian Iffland voted on patch set 1 CR +1 V +1 03/02/25, 09:49

  7. Garvin Hicking voted on patch set 1 CR +2 V +2 03/02/25, 10:28

  8. Garvin Hicking merged patch set 2 03/02/25, 10:28