87992[BUGFIX] Prevent PHP Warning in CKEditor5Migrator
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1013
-
Christian Weiske uploaded patch set 1 02/03/25, 09:28
-
core-ci voted on patch set 1 V +1 02/03/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73369
-
Oli Bartsch commented on patch set 1 V -1 02/03/25, 15:44
Hi, thanks for your patch. Looking at the migration in general, I think we should add the same functionality to migrateRemovePlugins(), too. Let's please also add some test, similar to https://review.typo3.org/c/Packages/TYPO3.CMS/+/78960. Additionally, the Releases line should be: main, 13.4, 12.4 -
Oli Bartsch commented on patch set 1 02/03/25, 15:44
Reply
- unresolve comment -
Christian Weiske uploaded patch set 2
V +102/04/25, 07:19 -
core-ci voted on patch set 2 V +1 02/04/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73464
-
Oli Bartsch uploaded patch set 3
V +102/04/25, 11:02 -
Oli Bartsch voted on patch set 3 CR +1 V +1 02/04/25, 11:03
-
core-ci voted on patch set 3 V +1 02/04/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73482
-
Christian Kuhn voted on patch set 3 CR +1 V +1 02/04/25, 11:18
-
Oli Bartsch voted on patch set 3 CR +2 V +2 02/04/25, 11:20
-
Oli Bartsch merged patch set 4 02/04/25, 11:20