Review main Merged

87992[BUGFIX] Prevent PHP Warning in CKEditor5Migrator

Christian Weiske CR +2 V +2 Normal +156 −4 updated 02/04/25, 11:20

Commit message

In CKEditor 4 the options "extraPlugins" and "removePlugins"
can be a comma separated list of strings.
CKEditor5Migrator now respects the old string value and converts
it to an array before migrating the value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Christian Weiske uploaded patch set 1 02/03/25, 09:28

  2. core-ci voted on patch set 1 V +1 02/03/25, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73369

  3. Oli Bartsch commented on patch set 1 V -1 02/03/25, 15:44

    Hi, thanks for your patch. Looking at the migration in general, I think we should add the same functionality to migrateRemovePlugins(), too. Let's please also add some test, similar to https://review.typo3.org/c/Packages/TYPO3.CMS/+/78960. Additionally, the Releases line should be: main, 13.4, 12.4
  4. Oli Bartsch commented on patch set 1 02/03/25, 15:44

    Reply

    - unresolve comment
  5. Christian Weiske uploaded patch set 2 V +1 02/04/25, 07:19

  6. Christian Weiske commented on patch set 2 02/04/25, 07:21

    Reply

    Done
    Fixed.
  7. core-ci voted on patch set 2 V +1 02/04/25, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73464

  8. Oli Bartsch uploaded patch set 3 V +1 02/04/25, 11:02

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 02/04/25, 11:03

  10. core-ci voted on patch set 3 V +1 02/04/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73482

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 02/04/25, 11:18

  12. Oli Bartsch voted on patch set 3 CR +2 V +2 02/04/25, 11:20

  13. Oli Bartsch merged patch set 4 02/04/25, 11:20