Review main Merged

87997[BUGFIX] Prevent array to string conversion in backend password reset

Torben Hansen CR +2 V +2 Easy +3 −5 updated 02/03/25, 18:37

Commit message

Submitting an array instead of a string in the backend password
reset form triggers a warning and 503 error due to
`GeneralUtility::validEmail()` function expecting a string.

This change ensures, that the submitted email address in the
password reset form is always treated as a string. If a
non-string value is detected, it will be safely reset to an
empty string.

Additionally, one unused variable and two superfluous doc
comments have been removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Alexander Frey +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Torben Hansen uploaded patch set 1 02/03/25, 15:03

  2. Torben Hansen updated the commit message in patch set 2 02/03/25, 15:07

  3. core-ci voted on patch set 1 V +1 02/03/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73411

  4. core-ci voted on patch set 2 V +1 02/03/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73412

  5. Alexander Frey voted on patch set 2 CR +1 02/03/25, 15:14

  6. Christian Kuhn voted on patch set 2 CR +1 02/03/25, 17:07

  7. Christian Kuhn voted on patch set 2 V +1 02/03/25, 17:14

  8. Georg Ringer voted on patch set 2 CR +1 V +1 02/03/25, 18:36

  9. Georg Ringer voted on patch set 2 CR +2 02/03/25, 18:36

  10. Georg Ringer voted on patch set 2 V +2 02/03/25, 18:36

  11. Georg Ringer merged patch set 3 02/03/25, 18:37