88014[WIP][BUGFIX] Allow "additionalParams" for external URL Typolink parsing
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 2
Review log 45
-
Garvin Hicking uploaded patch set 1 02/04/25, 12:24
-
core-ci voted on patch set 1 V -1 02/04/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73490
-
Garvin Hicking commented on patch set 1 CR -1 02/04/25, 13:41
Wll change to feature + rest + test change. behavioral change not wanted for <v14 -
Garvin Hicking commented on patch set 1 CR -2 02/04/25, 15:48
I will abandon this: additionalParams has been implemented to NOT apply to external links since at least TYPO3 6.2 - such a behavioral change might lead to leaking sensitive internal URI arguments. The LinkBuilder cannot easily be enhanced with a new attribute like "externalAdditionalParams" (because of the various input formats). I think the best route to got for an implementation like this is to add a new PSR-14 event like "ModifyPageLinkConfigurationEvent" also to the ExternalUrlLinkBuilder, so that additional parameters can be added on PHP-side, without affecting existing VH/TS implementations. -
Garvin Hicking abandoned the change 02/04/25, 15:48