Review main Merged

88018[TASK] Streamline functional TreeControllerTest

Christian Kuhn CR +2 V +2 Normal +60 −144 updated 02/04/25, 18:48

Commit message

Omit complex subject instance creation by invoking
the protected subject method using reflection.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Kuhn uploaded patch set 1 02/04/25, 17:19

  2. Christian Kuhn updated the commit message in patch set 2 02/04/25, 17:20

  3. core-ci voted on patch set 1 V +1 02/04/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73519

  4. core-ci voted on patch set 2 V +1 02/04/25, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73520

  5. Andreas Nedbal voted on patch set 2 CR +1 V +1 02/04/25, 17:57

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 02/04/25, 18:13

  7. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 02/04/25, 18:20

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/04/25, 18:21

  9. core-ci voted on patch set 3 V +1 02/04/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73524

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 02/04/25, 18:36

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 02/04/25, 18:48

  12. Christian Kuhn merged patch set 4 02/04/25, 18:48