Review main Merged

88024[TASK] Partially merge workspaces hook dispatching to DH

Christian Kuhn CR +2 V +2 Easy +14 −13 updated 02/05/25, 07:45

Commit message

DataHandler commands version/new, version/clearWSID and
version/flush are a direct ping pong between DataHandler
and workspaces DataHandlerHook. There is no point in
keeping the dispatcher code within the workspaces hook.

The patch inlines this to DataHandler->process_cmdmap(),
which allows protecting `@internal` DataHandler->discard().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Christian Kuhn uploaded patch set 1 02/04/25, 21:21

  2. core-ci voted on patch set 1 V +1 02/04/25, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73536

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/04/25, 21:48

  4. core-ci voted on patch set 2 V +1 02/04/25, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73537

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 02/04/25, 22:06

  6. Anja Leichsenring commented on patch set 2 02/05/25, 07:28

    DataHandler.php:3427

    it's only a comment, but the placement makes no sense now.
  7. Benni Mack voted on patch set 2 CR +1 V +1 02/05/25, 07:28

  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 02/05/25, 07:33

  9. Christian Kuhn commented on patch set 2 02/05/25, 07:35

    DataHandler.php:3427 Reply

    kept current place. background: $commandIsProcessed is supposed to handled by consumers as reference - they can toggle true/false. I thought it's more clear to have that declaration *below* the call, but it does not help to deconfuse phpstorm / phpstan, so i went back to current location.
  10. Anja Leichsenring commented on patch set 3 CR +1 V +1 02/05/25, 07:35

    DataHandler.php:3427 Reply

    Done
  11. Stefan Bürk voted on patch set 3 CR +1 V +1 02/05/25, 07:37

  12. core-ci voted on patch set 3 V +1 02/05/25, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73558

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 02/05/25, 07:45

  14. Christian Kuhn merged patch set 4 02/05/25, 07:45