Review main Merged

88034[BUGFIX] Handle invalid site sets as a frontend rendering error

Benjamin Franzke CR +2 V +2 Normal +54 −6 updated 02/07/25, 14:51

Commit message

Sites with missing site sets are now detected during frontend
rendering and transformed into a page access failure in order
for sites to only be rendered if all sets are loaded.

This behaviour is more strict than before, but added to ensure
that sites are not silently rendered in degraded state without
ever noticing this issue (soft-500).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benjamin Franzke uploaded patch set 1 02/05/25, 13:35

  2. core-ci voted on patch set 1 V -1 02/05/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73586

  3. Benjamin Franzke uploaded patch set 2 V -1 02/05/25, 14:03

  4. core-ci voted on patch set 2 V +1 02/05/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73587

  5. Lina Wolf commented on patch set 2 CR +1 V +1 02/06/25, 13:17

    Code looks good to me and works as expected. The error message is much easier to understand then the previous "No page configured for type=0.". I think this will make life of integrators easier. However currently you are using the same error number as the No page configured for type=0 error. I would prefer to have a unique error number so that the linked error page can also be tailored uniquely to the issues that might cause invalid sets
  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 02/06/25, 14:33

  7. Benjamin Franzke commented on patch set 3 02/06/25, 14:33

    Reply

    ack, added a distinct `PageAccessFailureReasons::INVALID_SITE_SETS` value.
  8. core-ci voted on patch set 3 V +1 02/06/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73668

  9. Benjamin Franzke uploaded patch set 4 V +1 02/06/25, 15:38

  10. core-ci voted on patch set 4 V +1 02/06/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73673

  11. Benni Mack voted on patch set 4 CR +1 02/07/25, 11:07

  12. Christian Kuhn voted on patch set 4 CR +1 02/07/25, 13:29

  13. Lina Wolf commented on patch set 4 CR +1 V +1 02/07/25, 13:42

    Just tested it with my broken site sets sitepackage and looks good to me.
  14. Christian Kuhn voted on patch set 4 V +1 02/07/25, 13:53

  15. Benjamin Franzke voted on patch set 4 CR +2 V +2 02/07/25, 14:39

  16. Benjamin Franzke merged patch set 5 02/07/25, 14:51