88034[BUGFIX] Handle invalid site sets as a frontend rendering error
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Lina Wolf +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Lina Wolf +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1216
-
Benjamin Franzke uploaded patch set 1 02/05/25, 13:35
-
core-ci voted on patch set 1 V -1 02/05/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73586
-
Benjamin Franzke uploaded patch set 2
V -102/05/25, 14:03 -
core-ci voted on patch set 2 V +1 02/05/25, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73587
-
Lina Wolf commented on patch set 2 CR +1 V +1 02/06/25, 13:17
Code looks good to me and works as expected. The error message is much easier to understand then the previous "No page configured for type=0.". I think this will make life of integrators easier. However currently you are using the same error number as the No page configured for type=0 error. I would prefer to have a unique error number so that the linked error page can also be tailored uniquely to the issues that might cause invalid sets -
Benjamin Franzke uploaded patch set 3
CR +1V +102/06/25, 14:33 -
Benjamin Franzke commented on patch set 3 02/06/25, 14:33
Reply
ack, added a distinct `PageAccessFailureReasons::INVALID_SITE_SETS` value. -
core-ci voted on patch set 3 V +1 02/06/25, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73668
-
Benjamin Franzke uploaded patch set 4
V +102/06/25, 15:38 -
core-ci voted on patch set 4 V +1 02/06/25, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73673
-
Benni Mack voted on patch set 4 CR +1 02/07/25, 11:07
-
Christian Kuhn voted on patch set 4 CR +1 02/07/25, 13:29
-
Lina Wolf commented on patch set 4 CR +1 V +1 02/07/25, 13:42
Just tested it with my broken site sets sitepackage and looks good to me. -
Christian Kuhn voted on patch set 4 V +1 02/07/25, 13:53
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 02/07/25, 14:39
-
Benjamin Franzke merged patch set 5 02/07/25, 14:51