Review main Merged

88040[TASK] Dissolve DataHandler->eventPid()

Christian Kuhn CR +2 V +2 Easy +8 −26 updated 02/05/25, 19:45

Commit message

The method fits no good purpose but rather makes things
more complicated than they should be and can be inlined
to consumers easily.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/05/25, 19:15

  2. Christian Kuhn updated the commit message in patch set 2 02/05/25, 19:16

  3. core-ci voted on patch set 1 V +1 02/05/25, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73604

  4. core-ci voted on patch set 2 V +1 02/05/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73605

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 02/05/25, 19:25

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 02/05/25, 19:26

  7. Benni Mack voted on patch set 2 CR +1 V +1 02/05/25, 19:29

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/05/25, 19:43

  9. Christian Kuhn merged patch set 3 02/05/25, 19:45