Review main Merged

88042[TASK] Dissolve DataHandler->doesRecordExist()

Christian Kuhn CR +2 V +2 Normal +41 −58 updated 02/05/25, 22:17

Commit message

When the DataHandler processes records, it tends to fetch
the record in question from DB over an over again.
This multiplies to huge counts of identical select queries,
which is a main reason for poor DataHandler performance.

This patch is a preparation to refactor some parts of this.

The idea is to hand over the current record in question in
between detail methods when possible.

One area to look at is recordInfoWithPermissionCheck(), its
consumers and its sub methods. recordInfoWithPermissionCheck()
will change its signature to get the record hand over with
another change.

As preparation, this patch takes care of two details:
* public but `@internal` doesRecordExist() is a wrapper
  of recordInfoWithPermissionCheck(). Consumers now use
  recordInfoWithPermissionCheck() directly, doesRecordExist()
  is removed.
* recordInfoWithPermissionCheck() removes its $fieldList
  argument and always selects '*': Some of the sub methods
  trigger this already if the fetched record is incomplete,
  leading to yet another query. This is avoided now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Christian Kuhn uploaded patch set 1 02/05/25, 20:11

  2. core-ci voted on patch set 1 V -1 02/05/25, 20:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73607

  3. Christian Kuhn uploaded patch set 2 V -1 02/05/25, 20:28

  4. Christian Kuhn uploaded patch set 3 02/05/25, 20:34

  5. core-ci voted on patch set 2 V -1 02/05/25, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73608

  6. core-ci voted on patch set 3 V +1 02/05/25, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73609

  7. Benni Mack voted on patch set 3 CR +1 V +1 02/05/25, 20:42

  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 02/05/25, 21:39

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 02/05/25, 22:17

  10. Christian Kuhn merged patch set 4 02/05/25, 22:17