Review main Abandoned

88047[POC][BUGFIX] Allow Extension scanner to handle method concatenation

Garvin Hicking CR 0 V 0 Normal +196 −6 updated 02/07/25, 13:00

Commit message

This does not spark joy: The Extension Scanner chokes on concatenated
method calls.

This patch aims to showcase that statical analysis of concatenated
method calls is a setup for failure and will not yield expected
results: Dynamic arguments cannot be resolved, leading to moot
results in scanning.

It is probably better to just gracefully ignore these calls
and make existing matchers not fail.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 10

Review log 610

  1. Garvin Hicking uploaded patch set 1 02/06/25, 08:36

  2. Garvin Hicking uploaded patch set 2 02/06/25, 08:39

  3. Garvin Hicking commented on patch set 2 02/06/25, 08:45

  4. core-ci voted on patch set 1 V -1 02/06/25, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73631

  5. core-ci voted on patch set 2 V -1 02/06/25, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73632

  6. Garvin Hicking uploaded patch set 3 V -1 02/06/25, 09:08

  7. core-ci voted on patch set 3 V -1 02/06/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73637

  8. Garvin Hicking commented on patch set 4 V -1 02/06/25, 09:22

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 02/06/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73639

  10. Garvin Hicking abandoned the change 02/07/25, 13:00

    radio has no future