Review main Merged

88049[BUGFIX] Prevent invisible overflow in list module

Benjamin Kott CR +2 V +2 Normal +58 −4 updated 02/07/25, 11:05

Commit message

We are replacing Bootstrap's visually-hidden approach
to gain more control over element behavior. The current
implementation causes invisible elements to be placed
absolutely within a scrollable area, making the view
scrollable due to their positioning relative to the
document instead of the container.

Since our overflowing lists are not relatively placed
to allow dropdowns to remain visible, we now position
visually hidden elements at the document flow start.
This prevents them from occupying unintended space.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Benjamin Kott uploaded patch set 1 02/06/25, 10:39

  2. Benjamin Kott commented on patch set 1 02/06/25, 10:40

    To validate, please use the record pages and select multiple columns in the list view so you get a scroll bar, please include "REF" column. You should now be able to scroll the whole view without any visible element appearing. This patch resolves this behavior.
  3. core-ci voted on patch set 1 V +1 02/06/25, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73645

  4. Benjamin Franzke voted on patch set 1 CR +1 V +1 02/06/25, 15:41

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 02/07/25, 10:54

  6. Benjamin Kott voted on patch set 1 CR +2 V +2 02/07/25, 10:56

  7. Benjamin Kott merged patch set 2 02/07/25, 11:05