88050[TASK] Allow markdown syntax in settings descriptions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 18
- Build/Sources/Sass/component/_settings.scss+27 −0
- Build/Sources/TypeScript/backend/settings/editor/editable-setting.ts+3 −2
- Build/Sources/TypeScript/backend/settings/editor.ts+4 −1
- Build/Sources/TypeScript/core/directive/markdown.tsnew+82 −0
- Build/Gruntfile.js+4 −0
- Build/package-lock.json+26 −3
- Build/package.json+2 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+5 −1
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor/editable-setting.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/settings/editor.js+6 −4
- typo3/sysext/core/Configuration/JavaScriptModules.php+2 −0
- typo3/sysext/core/Documentation/Changelog/13.1/Feature-103437-IntroduceSiteSets.rst2+3 −1
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/dompurify.jsnew+2 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/marked.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/directive/markdown.jsnew+13 −0
- typo3/sysext/felogin/Configuration/Sets/Felogin/labels.xlf+3 −1
- typo3/sysext/fluid_styled_content/Configuration/Sets/FluidStyledContent/labels.xlf2+9 −5
- typo3/sysext/redirects/Configuration/Sets/redirects/labels.xlf2+4 −1
Review log 2028
Show 23 earlier messages
-
Benjamin Franzke uploaded patch set 1 02/06/25, 10:41
-
core-ci voted on patch set 1 V +1 02/06/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73646
-
Benjamin Franzke uploaded patch set 2
V +102/06/25, 11:17
-
core-ci voted on patch set 2 V +1 02/06/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73647
-
Benjamin Franzke voted on patch set 2 CR -1 02/06/25, 11:56
-
Benjamin Franzke uploaded patch set 3
CR -1V +102/06/25, 13:59 -
core-ci voted on patch set 3 V +1 02/06/25, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73661
-
Benjamin Franzke uploaded patch set 4
V +102/06/25, 14:08 -
core-ci voted on patch set 4 V +1 02/06/25, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73664
-
Garvin Hicking commented on patch set 4 02/06/25, 14:16
-
Benjamin Franzke uploaded patch set 5
V +102/07/25, 14:16 -
Benjamin Franzke commented on patch set 5 02/07/25, 14:16
Feature-103437-IntroduceSiteSets.rst:72ReplyI'd argue that a category description should be plaintext-only as code blocks or what-not would clutter the interface – but I'm not strongly against it and I'm fine with supporting it (with the hope that it is not misued to add too long descriptions…) -
Benjamin Franzke uploaded patch set 6 02/07/25, 14:20
-
core-ci voted on patch set 5 V +1 02/07/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73734
-
core-ci voted on patch set 6 V +1 02/07/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73735
-
Benjamin Kott commented on patch set 6 CR -1 V -1 02/07/25, 15:22
missing null checks -
Benjamin Franzke uploaded patch set 7
CR -1V +102/07/25, 15:28 -
Benjamin Franzke commented on patch set 7 02/07/25, 15:29
Reply
Thanks! Fixed. -
Benjamin Kott voted on patch set 7 CR +1 V +1 02/07/25, 15:36
-
core-ci voted on patch set 7 V +1 02/07/25, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73747
-
Andreas Wolf commented on patch set 7 CR +1 02/07/25, 20:30
Looks good except for two nitpicks on the labels.labels.xlf:36The "" around the values should probably be removed if we code-highlight them, or?labels.xlf:30disable => disables -
Benjamin Franzke uploaded patch set 8
CR +1V +102/09/25, 06:14 -
Benjamin Franzke commented on patch set 8 02/09/25, 06:14
labels.xlf:36ReplyAck, I actually kept it because Backtick-Backtick was printed as-is and not as `<code></code>` by the markdown parser in the case for the `settings.description.styles.content.links.keep` label where an empty-string is shown as an example. Therefore I kept `"` in all cases for consistency. Anyway, I like it better without `"` as well and therefore used another workaround using `<code> </code>` (not ideal either, but better than placing `"` all over the place) for `settings.description.styles.content.links.keep` and adapted the styling to make spaces in code blocks visible.labels.xlf:30ReplyThanks, fixed! -
core-ci voted on patch set 8 V +1 02/09/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73827
-
Andreas Kienast voted on patch set 8 CR +1 V +1 02/10/25, 11:21
-
Benjamin Kott voted on patch set 8 CR +1 V +1 02/10/25, 11:22
-
Andreas Kienast voted on patch set 8 CR +2 V +2 02/10/25, 11:22
-
Andreas Kienast merged patch set 9 02/10/25, 11:29
Feature-103437-IntroduceSiteSets.rst:72