Review main Merged

88051[TASK] Streamline `ExpressionBuilder::like()` and `notLike()` tests

Stefan Bürk CR +2 V +2 Expert +781 −317 updated 02/06/25, 14:20

Commit message

This change extracts `like/notLike` related ExpressionBuilder
tests to a subfolder and adds additional tests:

* `TEXT` field like/notLike tests
* `VARCHAR` field like/notKike tests
* `INT` field like/notLike tests, disabled for PostgresSQL.

This is a preparation for #106085 and other future changes on
topics revealed meanwhile (case-sensitive/case-insensitive).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 913

  1. Stefan Bürk uploaded patch set 1 02/06/25, 11:50

  2. core-ci voted on patch set 1 V -1 02/06/25, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73648

  3. Stefan Bürk uploaded patch set 2 V -1 02/06/25, 12:17

  4. core-ci voted on patch set 2 V +1 02/06/25, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73649

  5. Stefan Bürk uploaded patch set 3 V +1 02/06/25, 13:06

  6. core-ci voted on patch set 3 V +1 02/06/25, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73654

  7. Christian Kuhn uploaded patch set 4 V +1 02/06/25, 13:34

  8. Christian Kuhn commented on patch set 4 02/06/25, 13:34

    ext_tables.sql:35

    you now have 3 different indention mechanisms in this file.
  9. Christian Kuhn commented on patch set 4 CR +1 V +1 02/06/25, 13:35

    ext_tables.sql:35 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/06/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73658

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 02/06/25, 13:58

  12. Stefan Bürk voted on patch set 4 CR +2 V +2 02/06/25, 14:12

  13. Stefan Bürk merged patch set 5 02/06/25, 14:20