Review main Merged

88052[TASK] Remove sys_log DB field details_nr

Christian Kuhn CR +2 V +2 Hard +148 −203 updated 02/07/25, 10:58

Commit message

"$details_nr The message number. Specific for each $type and
$action. in the future this will make it possible to translate
error messages to other languages"

This never happened.

Field `details_nr` in table `sys_log` is nearly completely
unused: CLI command `syslog:list` only outputs it in verbose
mode, the belog module doesn't at all. There is no information
about the integers being logged, many consumers fall back to
`-1` or `0`, some use a number that looks rather random.

There is a single use in ext:belog related to the "delete similar
errors" functionality:
"If the detailsNo is 11 or 12 we got messages that are heavily
using placeholders. In this case we need to compare both the
message and the actual log data to not remove too many log entries."
11 and 12 are used 4 times. Nowadays most log rows "heavily use"
placeholders, the exception for 11 and 12 doesn't make sense anymore.

The patch removes the entire handling of `details_nr` including
its `sys_log` table column. The API methods are changed and
annotate null as value so PHPStan finds places that still set
some value.

The DB field did default to zero, so it does not harm to not
insert a value during write. This is good for instances that
do not remove the column immediately.

The patch requests to be backported to v13: It should not harm
in existing instances during upgrades and it helps with further
v13 maintenance when main vs. 13.4 are kept identical with this
patch that changes many single places. The v13 version of the
patch will however keep the DB field itself to zero any chance
of a breaking change in case some extension inserts rows manually.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 1622

  1. Christian Kuhn uploaded patch set 1 02/06/25, 12:33

  2. core-ci voted on patch set 1 V -1 02/06/25, 12:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73650

  3. Christian Kuhn uploaded patch set 2 V -1 02/06/25, 12:59

  4. core-ci voted on patch set 2 V +1 02/06/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73653

  5. Christian Kuhn uploaded patch set 3 V +1 02/06/25, 14:00

  6. Christian Kuhn updated the commit message in patch set 4 02/06/25, 14:04

  7. Stefan Bürk voted on patch set 4 CR +1 V +1 02/06/25, 14:10

  8. core-ci voted on patch set 3 V +1 02/06/25, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73662

  9. core-ci voted on patch set 4 V +1 02/06/25, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73663

  10. Christian Kuhn uploaded patch set 5 CR +1 V +1 02/06/25, 16:33

  11. core-ci voted on patch set 5 V +1 02/06/25, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73674

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 02/06/25, 17:10

  13. Wouter Wolters commented on patch set 5 02/06/25, 18:05

    completely 😊
  14. Oliver Klee updated the commit message in patch set 6 CR +1 V +1 02/06/25, 18:45

  15. Oliver Klee commented on patch set 6 02/06/25, 18:45

    Reply

    Done
  16. Oliver Klee commented on patch set 6 02/06/25, 18:45

    Reply

    Done
  17. core-ci voted on patch set 6 V +1 02/06/25, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73676

  18. Anja Leichsenring voted on patch set 6 CR +1 V +1 02/06/25, 20:37

  19. Benni Mack voted on patch set 6 CR +1 V +1 02/07/25, 10:20

  20. Stefan Bürk voted on patch set 6 CR +1 V +1 02/07/25, 10:44

  21. Christian Kuhn voted on patch set 6 CR +2 V +2 02/07/25, 10:57

  22. Christian Kuhn merged patch set 7 02/07/25, 10:58