Review main Merged

88054[TASK] Have stateless GroupResolver

Christian Kuhn CR +2 V +2 Normal +71 −73 updated 02/06/25, 16:28

Commit message

This one is straight: Two properties are now constants,
the other one is hand around between protected methods.
The service is now readonly and shared.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Christian Kuhn uploaded patch set 1 02/06/25, 13:22

  2. core-ci voted on patch set 1 V +1 02/06/25, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73657

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/06/25, 13:39

  4. Christian Kuhn updated the commit message in patch set 3 02/06/25, 13:41

  5. core-ci voted on patch set 2 V +1 02/06/25, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73659

  6. core-ci voted on patch set 3 V +1 02/06/25, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73660

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 02/06/25, 14:01

  8. Georg Ringer commented on patch set 3 CR +1 V +1 02/06/25, 14:07

    should we also backport that?
  9. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/06/25, 14:20

  10. Christian Kuhn commented on patch set 3 02/06/25, 16:27

    Reply

    probably not i'd say: not important enough and it won't be a huge v13 amintenance headache if main&v13 are slightly different in this area.
  11. Christian Kuhn voted on patch set 3 CR +2 V +2 02/06/25, 16:28

  12. Christian Kuhn merged patch set 4 02/06/25, 16:28