88058[TASK] Refine site set error handling
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 2
Files 24
- Build/Scripts/runTests.sh+1 −1
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+3 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+12 −0
- typo3/sysext/backend/Resources/Private/Templates/SiteConfiguration/Overview.html+27 −0
- typo3/sysext/core/Classes/Command/SiteSetsListCommand.php+26 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+36 −25
- typo3/sysext/core/Classes/Site/Set/InvalidCategoryDefinitionsException.phpnew+41 −0
- typo3/sysext/core/Classes/Site/Set/InvalidSetException.php+22 −1
- typo3/sysext/core/Classes/Site/Set/InvalidSettingsException.php+3 −0
- typo3/sysext/core/Classes/Site/Set/SetError.php+4 −0
- typo3/sysext/core/Classes/Site/Set/SetRegistry.php+20 −7
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+152 −52
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+8 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptySettings/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/EmptySettings/settings.yamlnew+0 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidChainedDependeny/config.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSetMissingLabel/config.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettings/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettings/settings.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsInvalidType/config.yamlnew+2 −0
Show 4 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsInvalidType/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsMissingProperties/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/Sets/InvalidSettingsDefinitionsMissingProperties/settings.definitions.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Site/Set/SetRegistryTest.php+62 −3
Review log 34
-
Benjamin Franzke uploaded patch set 1 02/06/25, 15:20
-
core-ci voted on patch set 1 V +1 02/06/25, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73671
-
Benjamin Franzke commented on patch set 1 CR +2 V +2 02/06/25, 15:34
This change is ready for review. -
Benjamin Franzke merged patch set 2 02/06/25, 15:34