Review main Merged

88059[BUGFIX] Fix incorrect position handling in addRecordType()

Oli Bartsch CR +2 V +2 Normal +65 −1 updated 02/07/25, 08:31

Commit message

The `addRecordType()` utility method now correctly
forwards the "<position>:<fieldname>" syntax
(e.g., "after:textpic") to the underlying
`addTcaSelectItem() call.

Previously, the field name was incorrectly passed
as the position, triggering an `InvalidArgumentException`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • David Steeb +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • David Steeb +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 02/06/25, 17:18

  2. core-ci voted on patch set 1 V +1 02/06/25, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73675

  3. Benni Mack voted on patch set 1 CR +1 V +1 02/06/25, 21:33

  4. David Steeb voted on patch set 1 CR +1 V +1 02/06/25, 21:41

  5. Jochen Roth voted on patch set 1 CR +1 V +1 02/07/25, 08:09

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 02/07/25, 08:31

  7. Oli Bartsch merged patch set 2 02/07/25, 08:31