Review main Merged

88063[TASK] Streamline DataHandler->process_datamap()

Christian Kuhn CR +2 V +2 Hard +151 −185 updated 02/07/25, 12:15

Commit message

The patch aims to improve readability of process_datamap()
by calling continue early in case of failing access checks
and improving a series of comments. A couple of types are
added along the way that would already fail at earlier
positions if not satisfied: Especially TcaSchema helps
here with its rather strict typing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1015

  1. Christian Kuhn uploaded patch set 1 02/07/25, 00:16

  2. core-ci voted on patch set 1 V -1 02/07/25, 00:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73681

  3. Christian Kuhn uploaded patch set 2 V -1 02/07/25, 00:41

  4. core-ci voted on patch set 2 V +1 02/07/25, 00:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73682

  5. Christian Kuhn updated the commit message in patch set 3 V +1 02/07/25, 00:51

  6. Christian Kuhn updated the commit message in patch set 4 02/07/25, 00:52

  7. core-ci voted on patch set 3 V +1 02/07/25, 00:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73683

  8. core-ci voted on patch set 4 V +1 02/07/25, 01:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73684

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 02/07/25, 08:35

  10. Christian Kuhn uploaded patch set 5 CR +1 V +1 02/07/25, 11:09

  11. core-ci voted on patch set 5 V +1 02/07/25, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73715

  12. Oli Bartsch voted on patch set 5 CR +1 V +1 02/07/25, 11:53

  13. Stefan Bürk voted on patch set 5 CR +1 V +1 02/07/25, 12:02

  14. Christian Kuhn voted on patch set 5 CR +2 V +2 02/07/25, 12:15

  15. Christian Kuhn merged patch set 6 02/07/25, 12:15