Review main Merged

88066[BUGFIX] Fix file tree crash with broken offline storage

Christian Weiske CR +2 V +2 Easy +4 −1 updated 02/10/25, 21:46

Commit message

When a file storage has an incomplete/broken configuration and is set
"offline", the file tree still tried to load processing folders and
subfolders from the storage.

This patch fixes this, making the file tree work for broken offline
storages.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Weiske uploaded patch set 1 02/07/25, 09:42

  2. Christian Weiske commented on patch set 1 02/07/25, 09:42

    I only tested this on 12.4.26, not on 13.4 or main.
  3. core-ci voted on patch set 1 V +1 02/07/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73703

  4. Georg Ringer voted on patch set 1 CR +1 V +1 02/09/25, 21:15

  5. Christian Kuhn commented on patch set 1 CR +1 V +1 02/10/25, 14:08

    i played around on this with the mentioned s3 extension (in v12 only) and confirm the issue. the patch fixes in this scenario. with debugging through v14, it looks identical. i think this change is fine, but it would be great to have another eye on the surrounding codebase, so i'm currently still a bit hesitant to merge right away.
  6. Benni Mack voted on patch set 1 CR +1 V +1 02/10/25, 21:15

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 02/10/25, 21:46

  8. Christian Kuhn merged patch set 2 02/10/25, 21:46