Review 13.4 Merged

88067[TASK] Declare DH->process_datamap() returns void

Christian Kuhn CR +2 V +2 Easy +4 −46 updated 02/07/25, 10:27

Commit message

DataHandler->process_datamap() almost always returns void.
The single exception is a seldom matching early return
false in case the user is in a workspace and the workspace
is frozen.

There are many other failure cases and the general
DataHandler strategy is to log them and skip further
processing without returning result status. Developers
taking care of sucessful DH operations thus have to check
DH->errorLog anyways. The false return for the above
single error case is only additional overhead from this
point of view making everything even more complex.

The patch avoids this return false and declares return
void in process_datamap().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/07/25, 10:05

  2. core-ci voted on patch set 1 V +1 02/07/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73705

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/07/25, 10:27

  4. Christian Kuhn merged patch set 2 02/07/25, 10:27