Review 13.4 Merged

88068[TASK] Skip an unused argument in DH->insertDB()

Christian Kuhn CR +2 V +2 Easy +3 −6 updated 02/07/25, 10:30

Commit message

Sixth argument $dontSetNewIdIndex is never set to true
by the few consumers. The patch removes the argument.

The patch also declares the `@internal` method protected.
This detail will not be backported to v13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/07/25, 10:13

  2. core-ci voted on patch set 1 V +1 02/07/25, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73706

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/07/25, 10:30

  4. Christian Kuhn merged patch set 2 02/07/25, 10:30