Review 13.4 Merged

88075[TASK] Streamline DataHandler->process_datamap()

Christian Kuhn CR +2 V +2 Hard +151 −185 updated 02/07/25, 12:15

Commit message

The patch aims to improve readability of process_datamap()
by calling continue early in case of failing access checks
and improving a series of comments. A couple of types are
added along the way that would already fail at earlier
positions if not satisfied: Especially TcaSchema helps
here with its rather strict typing.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/07/25, 12:05

  2. core-ci voted on patch set 1 V +1 02/07/25, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73723

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 02/07/25, 12:15

  4. Christian Kuhn merged patch set 2 02/07/25, 12:15