Review main Merged

88077[BUGFIX] Fix site set label loading on windows

Benjamin Franzke CR +2 V +2 Easy +37 −13 updated 02/12/25, 16:43

Commit message

The site set labels are loaded via an absolute
file path. That means a string like
LLL:C:/web/typo3/sysext/seo/Configuration/Sets/Sitemap/labels.xlf:label
is passed to the language API, where three colons are included because
of drives on windows (`C:/`).

Adapt the LLL string parser to be able to parse this kind of label
and pick the language from the part after the last colon, instead of
omitting the entire string after the second colon.

Also remove a previous workaround which was added to circumvent
the same parsing issue for the colon of the `EXT:`-prefix, which
is no longer needed with this fix.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1216

  1. Benjamin Franzke uploaded patch set 1 02/07/25, 12:24

  2. core-ci voted on patch set 1 V +1 02/07/25, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73725

  3. Benjamin Franzke uploaded patch set 2 V +1 02/07/25, 15:22

  4. core-ci voted on patch set 2 V -1 02/07/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73745

  5. Benjamin Franzke uploaded patch set 3 V -1 02/07/25, 15:29

  6. core-ci voted on patch set 3 V +1 02/07/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73748

  7. Christian Kuhn commented on patch set 3 02/07/25, 20:22

    LanguageService.php:194

    this overall magic could benefit from a comment explaining what is happening. what do you think?
  8. Benjamin Franzke uploaded patch set 4 V +1 02/09/25, 12:28

  9. Benjamin Franzke commented on patch set 4 02/09/25, 12:28

    LanguageService.php:194 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/09/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73834

  11. Christian Kuhn voted on patch set 4 CR +1 02/09/25, 13:12

  12. Christian Kuhn voted on patch set 4 V +1 02/09/25, 18:21

  13. Stefan Bürk voted on patch set 4 CR +1 V +1 02/09/25, 19:19

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 02/09/25, 19:25

  15. Christian Kuhn merged patch set 5 02/09/25, 19:33

  16. Benjamin Franzke wrote 02/12/25, 16:43

    Created a revert of this change as Ibda65710c3133fac15df97d3aa3a63b76e509c11