Review main Merged

88080[TASK] Clean up DataHandler checkModifyAccessList hook handling

Christian Kuhn CR +2 V +2 Normal +78 −129 updated 02/07/25, 16:33

Commit message

DH hooks implementing DataHandlerCheckModifyAccessListHookInterface
are handled in a funny way: Their instances are created once and
parked in a property. This makes them de facto singletons within a
DH instance.

Hook implementations however can not rely on this: DataHandler
tends to call itself recursive, and this state is not hand around,
still leading to new instances.

Additionally, this is of course a misuse: Single implementations
should know whether they can be `shared: true`, this is usually
nothing a caller should take care of.

The "park" strategy exists since ever and probably stems from an
era where object creation was expensive.

The patch removes this handling to hand the shared true/false
decision over to consuming hook implementations. The existing
implementations are cleaned up a bit along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 913

  1. Christian Kuhn uploaded patch set 1 02/07/25, 13:18

  2. core-ci voted on patch set 1 V +1 02/07/25, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73728

  3. Christian Kuhn uploaded patch set 2 V +1 02/07/25, 13:43

  4. Christian Kuhn updated the commit message in patch set 3 02/07/25, 13:45

  5. core-ci voted on patch set 2 V +1 02/07/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73730

  6. core-ci voted on patch set 3 V +1 02/07/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73732

  7. Anja Leichsenring updated the commit message in patch set 4 V +1 02/07/25, 14:59

  8. core-ci voted on patch set 4 V +1 02/07/25, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73744

  9. Anja Leichsenring voted on patch set 4 CR +1 V +1 02/07/25, 15:12

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 02/07/25, 16:17

  11. Benni Mack voted on patch set 4 CR +1 V +1 02/07/25, 16:24

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 02/07/25, 16:32

  13. Christian Kuhn merged patch set 5 02/07/25, 16:33