88083[TASK] Use Schema API in recycler
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php4+54 −62
- typo3/sysext/recycler/Classes/Domain/Model/DeletedRecords.php2+68 −95
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+27 −11
- typo3/sysext/recycler/Classes/Task/CleanerTask.php+44 −42
- typo3/sysext/recycler/Tests/Functional/Task/CleanerFieldProviderTest.php+5 −4
- typo3/sysext/recycler/Tests/Functional/Task/CleanerTaskTest.php+0 −1
Review log 1725
-
Benni Mack uploaded patch set 1 02/07/25, 14:35
-
Benni Mack marked it work in progress 02/07/25, 14:38
-
core-ci voted on patch set 1 V -1 02/07/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73738
-
Benni Mack uploaded patch set 2
V -102/10/25, 22:39 -
core-ci voted on patch set 2 V -1 02/10/25, 22:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73948
-
Benni Mack uploaded patch set 3
V -102/11/25, 14:06 -
core-ci voted on patch set 3 V -1 02/11/25, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73983
-
Benni Mack uploaded patch set 4
V -102/11/25, 14:28 -
core-ci voted on patch set 4 V -1 02/11/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73989
-
Benni Mack uploaded patch set 5
V -102/11/25, 14:41 -
core-ci voted on patch set 5 V -1 02/11/25, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73991
-
Benni Mack uploaded patch set 6
V -102/11/25, 15:24 -
core-ci voted on patch set 6 V +1 02/11/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73996
-
Benni Mack updated the commit message in patch set 7
V +102/11/25, 15:31 -
Benni Mack marked it ready for review 02/11/25, 15:31
-
core-ci voted on patch set 7 V +1 02/11/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73997
-
Andreas Kienast commented on patch set 7 02/12/25, 07:33
RecyclerAjaxController.php:396We have the same code in `TYPO3\CMS\Recycler\Domain\Model`. Can't we make that method public and use that instead?DeletedRecords.php:82`array_key_exists($table, $schemata)` -
Benni Mack uploaded patch set 8
V +102/13/25, 07:34 -
core-ci voted on patch set 8 V +1 02/13/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74103
-
Benni Mack commented on patch set 8 02/13/25, 07:42
RecyclerAjaxController.php:371ReplyDoneRecyclerAjaxController.php:396ReplyI put this on my list of Schema API improvements... wouldn't fix this right now.DeletedRecords.php:82ReplyDone -
Stefan Bürk voted on patch set 8 CR +1 02/13/25, 09:03
-
Stefan Bürk voted on patch set 8 V +1 02/13/25, 09:51
-
Andreas Kienast voted on patch set 8 CR +1 V +1 02/13/25, 15:43
-
Benni Mack voted on patch set 8 CR +2 V +2 02/16/25, 21:20
-
Benni Mack merged patch set 9 02/16/25, 21:20
RecyclerAjaxController.php:371