Review main Merged

88083[TASK] Use Schema API in recycler

Benni Mack CR +2 V +2 Hard +198 −215 updated 02/16/25, 21:20

Commit message

This change ensures to avoid any access to
$GLOBALS[TCA] in favor of Schema API in EXT:recycler.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1725

  1. Benni Mack uploaded patch set 1 02/07/25, 14:35

  2. Benni Mack marked it work in progress 02/07/25, 14:38

  3. core-ci voted on patch set 1 V -1 02/07/25, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73738

  4. Benni Mack uploaded patch set 2 V -1 02/10/25, 22:39

  5. core-ci voted on patch set 2 V -1 02/10/25, 22:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73948

  6. Benni Mack uploaded patch set 3 V -1 02/11/25, 14:06

  7. core-ci voted on patch set 3 V -1 02/11/25, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73983

  8. Benni Mack uploaded patch set 4 V -1 02/11/25, 14:28

  9. core-ci voted on patch set 4 V -1 02/11/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73989

  10. Benni Mack uploaded patch set 5 V -1 02/11/25, 14:41

  11. core-ci voted on patch set 5 V -1 02/11/25, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73991

  12. Benni Mack uploaded patch set 6 V -1 02/11/25, 15:24

  13. core-ci voted on patch set 6 V +1 02/11/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73996

  14. Benni Mack updated the commit message in patch set 7 V +1 02/11/25, 15:31

  15. Benni Mack marked it ready for review 02/11/25, 15:31

  16. core-ci voted on patch set 7 V +1 02/11/25, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73997

  17. Andreas Kienast commented on patch set 7 02/12/25, 07:33

    RecyclerAjaxController.php:371

    Both ifs() can be combined

    RecyclerAjaxController.php:396

    We have the same code in `TYPO3\CMS\Recycler\Domain\Model`. Can't we make that method public and use that instead?

    DeletedRecords.php:82

    `array_key_exists($table, $schemata)`
  18. Benni Mack uploaded patch set 8 V +1 02/13/25, 07:34

  19. core-ci voted on patch set 8 V +1 02/13/25, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74103

  20. Benni Mack commented on patch set 8 02/13/25, 07:42

    RecyclerAjaxController.php:371 Reply

    Done

    RecyclerAjaxController.php:396 Reply

    I put this on my list of Schema API improvements... wouldn't fix this right now.

    DeletedRecords.php:82 Reply

    Done
  21. Stefan Bürk voted on patch set 8 CR +1 02/13/25, 09:03

  22. Stefan Bürk voted on patch set 8 V +1 02/13/25, 09:51

  23. Andreas Kienast voted on patch set 8 CR +1 V +1 02/13/25, 15:43

  24. Benni Mack voted on patch set 8 CR +2 V +2 02/16/25, 21:20

  25. Benni Mack merged patch set 9 02/16/25, 21:20