Review main Merged Breaking

88086[!!!][TASK] Remove DataHandler->storeLogMessages

Christian Kuhn CR +2 V +2 Normal +45 −13 updated 02/07/25, 16:48

Commit message

DataHandler logging can be fully disabled by setting
property enableLogging to false. This can be used during
bulk inserts and is used for instance by ext:impexp.

The second property storeLogMessages is of much less use.
It states: "Disabling will just save some database-space
as the default messages are not saved". This is deemed
rather useless in 2025 database engines. It is also
never used within TYPO3 core itself. It is also unused
when looking at TER extensions.

In general, we want to either have full log rows or none
at all, but not incomplete ones since this especially
collides with data tuples used in message placeholders.

The patch removes the property and its handling.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/07/25, 16:18

  2. Christian Kuhn updated the commit message in patch set 2 02/07/25, 16:21

  3. core-ci voted on patch set 1 V +1 02/07/25, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73751

  4. core-ci voted on patch set 2 V +1 02/07/25, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73752

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/07/25, 16:37

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 02/07/25, 16:37

  7. Benni Mack voted on patch set 2 CR +1 V +1 02/07/25, 16:38

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/07/25, 16:48

  9. Christian Kuhn merged patch set 3 02/07/25, 16:48