Review main Merged

88088[TASK] Use Schema API in linkvalidator

Benni Mack CR +2 V +2 Normal +93 −62 updated 02/10/25, 13:19

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Wand +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1419

  1. Benni Mack uploaded patch set 1 02/07/25, 17:08

  2. core-ci voted on patch set 1 V -1 02/07/25, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73755

  3. Benni Mack uploaded patch set 2 V -1 02/07/25, 17:39

  4. core-ci voted on patch set 2 V +1 02/07/25, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73756

  5. Benni Mack updated the commit message in patch set 3 V +1 02/07/25, 22:09

  6. core-ci voted on patch set 3 V +1 02/07/25, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73777

  7. Christian Kuhn voted on patch set 3 CR +1 02/08/25, 06:32

  8. Oliver Wand voted on patch set 3 CR +1 02/08/25, 09:26

  9. Benni Mack updated the commit message in patch set 4 CR +1 V +1 02/09/25, 12:21

  10. core-ci voted on patch set 4 V +1 02/09/25, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73832

  11. Georg Ringer voted on patch set 4 CR +1 V +1 02/09/25, 21:17

  12. Christian Kuhn commented on patch set 4 CR -1 02/10/25, 12:26

    LinkValidatorController.php:343

    i think we need to factory->has() here first to not except if there is a row in tx_linkvalidator_link pointing to a table_name that does not exist anymore - this does not seem to be sanitized otherwise.
  13. Christian Kuhn uploaded patch set 5 CR +1 V +1 02/10/25, 12:38

  14. Christian Kuhn commented on patch set 5 CR +1 V +1 02/10/25, 12:39

    LinkValidatorController.php:343 Reply

    Done
  15. Georg Ringer voted on patch set 5 CR +1 V +1 02/10/25, 12:40

  16. core-ci voted on patch set 5 V +1 02/10/25, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73892

  17. Oliver Wand voted on patch set 5 CR +1 02/10/25, 12:52

  18. Christian Kuhn voted on patch set 5 CR +2 V +2 02/10/25, 13:09

  19. Christian Kuhn merged patch set 6 02/10/25, 13:19