Review main Merged

88089[TASK] Use Schema API in EXT:info

Benni Mack CR +2 V +2 Normal +44 −29 updated 02/08/25, 15:21

Commit message

This change replaces TCA usage from the info module
with the available Schema API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Wand +1
    • Christian Kuhn +1
    • Andreas Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Andreas Wolf +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benni Mack uploaded patch set 1 02/07/25, 17:52

  2. core-ci voted on patch set 1 V -1 02/07/25, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73757

  3. Benni Mack uploaded patch set 2 V -1 02/07/25, 19:39

  4. core-ci voted on patch set 2 V +1 02/07/25, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73769

  5. Benni Mack updated the commit message in patch set 3 V +1 02/07/25, 19:54

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 02/07/25, 19:59

  7. core-ci voted on patch set 3 V +1 02/07/25, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73770

  8. Andreas Wolf commented on patch set 3 CR +1 02/07/25, 20:14

    PageInformationController.php:127

    For consistency: Should this condition probably also be inverted, have a "continue" inside, and the $actual operation moved after it?
  9. Benni Mack commented on patch set 4 CR +1 V +1 02/07/25, 20:35

    Published edit on patch set 3.
  10. Benni Mack commented on patch set 4 02/07/25, 20:35

    PageInformationController.php:127 Reply

    Done
  11. Andreas Wolf voted on patch set 4 CR +1 V +1 02/07/25, 20:40

  12. core-ci voted on patch set 4 V +1 02/07/25, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73773

  13. Christian Kuhn voted on patch set 4 CR +1 V +1 02/08/25, 06:28

  14. Oliver Wand voted on patch set 4 CR +1 02/08/25, 09:26

  15. Benni Mack voted on patch set 4 CR +2 V +2 02/08/25, 15:21

  16. Benni Mack merged patch set 5 02/08/25, 15:21