Review main Merged

88092[TASK] Use Schema API in EXT:frontend

Benni Mack CR +2 V +2 Normal +128 −75 updated 02/20/25, 16:19

Commit message

This change removes any usages to $GLOBALS[TCA]
for reading in EXT:frontend in favor of Schema API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1622

  1. Benni Mack uploaded patch set 1 02/07/25, 20:31

  2. core-ci voted on patch set 1 V -1 02/07/25, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73772

  3. Oliver Wand voted on patch set 1 CR +1 02/08/25, 09:29

  4. Benni Mack uploaded patch set 2 CR +1 V -1 02/12/25, 08:12

  5. Oliver Wand voted on patch set 2 CR +1 02/12/25, 08:17

  6. core-ci voted on patch set 2 V -1 02/12/25, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74033

  7. Benni Mack updated the commit message in patch set 3 CR +1 V -1 02/18/25, 15:39

  8. core-ci voted on patch set 3 V -1 02/18/25, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74333

  9. Benni Mack uploaded patch set 4 V -1 02/18/25, 16:05

  10. core-ci voted on patch set 4 V -1 02/18/25, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74336

  11. Benni Mack uploaded patch set 5 V -1 02/18/25, 16:17

  12. core-ci voted on patch set 5 V +1 02/18/25, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74338

  13. Benni Mack rebased onto patch set 6 V +1 02/20/25, 11:34

  14. core-ci voted on patch set 6 V +1 02/20/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74463

  15. Georg Ringer commented on patch set 6 02/20/25, 11:46

    RecordsContentObject.php:173

    should we still check the TCA? didn't check the code but if there is a usage of a table in the code which has been removed, this should be checked
  16. Benni Mack commented on patch set 6 02/20/25, 11:47

    RecordsContentObject.php:173 Reply

    this is done in getDefaultConstraints() already
  17. Georg Ringer voted on patch set 6 CR +1 V +1 02/20/25, 15:28

  18. Georg Ringer commented on patch set 6 02/20/25, 15:28

    RecordsContentObject.php:173 Reply

    Acknowledged
  19. Stefan Bürk voted on patch set 6 CR +1 V +1 02/20/25, 16:14

  20. Benni Mack commented on patch set 6 02/20/25, 16:19

    thanks for the reviews!
  21. Benni Mack voted on patch set 6 CR +2 V +2 02/20/25, 16:19

  22. Benni Mack merged patch set 7 02/20/25, 16:19