88093[TASK] Use Schema API in EXT:extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −12
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+23 −15
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+64 −88
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+4 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+20 −0
Review log 1623
-
Benni Mack uploaded patch set 1 02/07/25, 20:58
-
core-ci voted on patch set 1 V -1 02/07/25, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73774
-
Oliver Wand voted on patch set 1 CR +1 02/08/25, 09:28
-
Benni Mack uploaded patch set 2
CR +1V -102/13/25, 20:36 -
core-ci voted on patch set 2 V -1 02/13/25, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74120
-
Benni Mack uploaded patch set 3
V -102/18/25, 10:06 -
core-ci voted on patch set 3 V -1 02/18/25, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74301
-
Benni Mack marked it work in progress 02/18/25, 11:19
-
Benni Mack uploaded patch set 4
V -102/18/25, 15:06 -
core-ci voted on patch set 4 V -1 02/18/25, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74328
-
Benni Mack uploaded patch set 5
V -102/18/25, 15:20 -
core-ci voted on patch set 5 V +1 02/18/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74329
-
Benni Mack updated the commit message in patch set 6
V +102/18/25, 15:37 -
Benni Mack marked it ready for review 02/18/25, 15:37
-
core-ci voted on patch set 6 V +1 02/18/25, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74332
-
Georg Ringer commented on patch set 6 CR +1 V +1 02/18/25, 15:59
a reason why not having that in 13? -
Benni Mack commented on patch set 6 02/18/25, 16:35
Reply
yes. a) some code was changed in that area b) like EXT:backend, EXT:core and EXT:frontend there might be some areas where people manipulate TCA during a request to achieve other results - this would be causing a regression in a bugfix release -
Christian Kuhn uploaded patch set 7
CR +1V +102/19/25, 17:01 -
core-ci voted on patch set 7 V +1 02/19/25, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/74404
-
Christian Kuhn voted on patch set 7 CR +1 V +1 02/19/25, 17:10
-
Stefan Bürk voted on patch set 7 CR +1 V +1 02/19/25, 17:39
-
Benni Mack voted on patch set 7 CR +2 V +2 02/19/25, 21:27
-
Benni Mack merged patch set 8 02/19/25, 21:28