Review main Merged

88095[TASK] Avoid $recpid in writelog()

Christian Kuhn CR +2 V +2 Normal +123 −125 updated 02/08/25, 09:38

Commit message

BackendUserAuthentication->writelog():
"int|string $recpid Record PID. Special field used by
tce_main.php. OBSOLETE"

The parameter is unused and not inserted to sys_log.

The patch changes the annotation to null and adapts
callers, including the wrapper method in DataHandler.

This reveals some callers like DataHandler->updateDB()
still submit a value, which is adapted with the patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Andreas Wolf +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 811

  1. Christian Kuhn uploaded patch set 1 02/08/25, 07:54

  2. core-ci voted on patch set 1 V +1 02/08/25, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73793

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/08/25, 08:07

  4. Christian Kuhn updated the commit message in patch set 3 02/08/25, 08:07

  5. core-ci voted on patch set 2 V +1 02/08/25, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73794

  6. core-ci voted on patch set 3 V +1 02/08/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73795

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/08/25, 08:23

  8. Andreas Wolf voted on patch set 3 CR +1 02/08/25, 08:53

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 02/08/25, 09:01

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 02/08/25, 09:33

  11. Christian Kuhn merged patch set 4 02/08/25, 09:38